Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add FUNCTION KILL command. #1560

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Issue #, if available:
N/A

Description of changes:
https://redis.io/docs/latest/commands/function-kill/

There is no transaction implementations, because Redis rejects transaction when blocked by a function/script.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yury-Fridlyand and others added 3 commits June 12, 2024 17:35
* Add `FUNCTION KILL` command.
* Frantic and rampant code clean up.
* More tests for the god of the tests!
* Address PR comments.
* Typo fix.
* Fixing the tests s02ep06.
* Fixing the tests s03ep01.
* Address PR comments.

Co-authored-by: aaron-congo <aaron.congo@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Jun 13, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner June 13, 2024 00:44
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 850fc10 into valkey-io:main Jun 13, 2024
46 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/integ_yuryf_fkill branch June 13, 2024 23:25
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Java: Add `FUNCTION KILL` command. (#328)

* Add `FUNCTION KILL` command.
* Frantic and rampant code clean up.
* More tests for the god of the tests!
* Address PR comments.
* Typo fix.
* Fixing the tests s02ep06.
* Fixing the tests s03ep01.
* Address PR comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: aaron-congo <aaron.congo@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants